Skip to content

Add topic attributes to Reader metrics - #788

Merged
alex268 merged 7 commits into
masterfrom
topic-reader-topic-attributes
Oct 27, 2026
Merged

alex268 merged 7 commits into
masterfrom
topic-reader-topic-attributes

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Добавляет атрибут topic к двум метрикам Reader:

  • ydb.topic.reader.partition_session.count
  • ydb.topic.reader.commit_offset.lag.max

topicPath хранится в существующем CommitOffsets внутри ReaderMetrics.partitions; обе метрики группируются по этой же map. ReadSession передаёт путь через существующий addPartition. Передача и захват Collection удалены; бизнес-логика коммитов и жизненный цикл партиций не меняются. При отсутствии партиций per-topic точки не публикуются.

Без topic остаются общие Reader-метрики received.bytes, local_buffer.messages, local_buffer.message_age.max, credit_balance_bytes и session.errors. Остальные topic-атрибуты Reader и Writer сохранены.

Проверено локально после удаления теста: 8 тестов ReaderMetricsTest/WriterMetricsTest, без failures/errors/skips; Checkstyle без нарушений. JDTLS недоступен; компиляция Maven успешна.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.97%. Comparing base (3ec170e) to head (c749e2b).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #788      +/-   ##
============================================
+ Coverage     75.95%   75.97%   +0.02%     
- Complexity     3841     3849       +8     
============================================
  Files           394      395       +1     
  Lines         17090    17123      +33     
  Branches       1810     1811       +1     
============================================
+ Hits          12980    13010      +30     
- Misses         3489     3493       +4     
+ Partials        621      620       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268
alex268 merged commit 190f0f0 into master Oct 27, 2026
16 checks passed
@alex268
alex268 deleted the topic-reader-topic-attributes branch October 27, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants